Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installer): Label field as username instead of login #49500

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HB9HIL
Copy link

@HB9HIL HB9HIL commented Nov 26, 2024

Summary

The intended username field in the installer is labeled "Login" which translates in many languages in a different meaning. It's better to label it Username.

Before:

image

After:

image

TODO

Nothing

Checklist

@solracsf

This comment was marked as resolved.

@solracsf solracsf added this to the Nextcloud 31 milestone Nov 27, 2024
@HB9HIL

This comment was marked as resolved.

@solracsf solracsf changed the title Installer - Username field in installer should not labeled "Login" fix(installer): Label field as username instead of login Nov 27, 2024
@joshtrichards
Copy link
Member

Good catch, @HB9HIL

to match the the other fields in v30

Signed-off-by: Fabian Berg <[email protected]>
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants